On Mon, Jun 26, 2017 at 05:31:45PM +0100, Bruce Richardson wrote: > On Mon, Jun 26, 2017 at 02:22:01AM +0200, Gaetan Rivet wrote: > > From: Jan Blunck <jblu...@infradead.org> > > > > Signed-off-by: Jan Blunck <jblu...@infradead.org> > > Signed-off-by: Gaetan Rivet <gaetan.ri...@6wind.com> > > --- > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > > lib/librte_eal/common/eal_common_bus.c | 25 > > +++++++++++++++++++++++++ > > lib/librte_eal/common/include/rte_bus.h | 5 +++++ > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > > 4 files changed, 32 insertions(+) > > > > Acked-by: Bruce Richardson <bruce.richard...@intel.com> > > Would it be useful to add a unit test for this function? That would help > with any future refactoring, and also indirectly test the other > functions added in the previous 2 patches.
Yes, I think it would be better to have unit-tests for those functions. They can be a little tricky to get right, working with the layers of callbacks. I may be short on time for the next version though. I'll see. -- Gaëtan Rivet 6WIND
