26/06/2017 11:14, Sergio Gonzalez Monroy: > On 23/06/2017 14:02, Thomas Monjalon wrote: > > 22/06/2017 17:15, Sergio Gonzalez Monroy: > >> Just fyi, the summary line should be lowercase apart from acronyms (DPDK > >> guidelines). > >> > >> On 11/05/2017 02:56, Tonghao Zhang wrote: > >>> The NUMA node information for PCI devices provided through > >>> sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx > >>> on Red Hat Enterprise Linux 6, and VMs on some hypervisors. > >>> It is good to see more checking for valid values. > >>> > >>> Signed-off-by: Tonghao Zhang <n...@opencloud.tech> > >>> --- > >> IMHO the message could be slightly improved by adding some of the > >> replies that you made to your v3. > >> ie. Typical wrong numa node in VMs > >> > >> $ cat /sys/devices/pci0000:00/0000:00:18.6/numa_node > >> -1 > > [...] > >> The code changes look fine, so I leave it to Thomas regarding the commit > >> message :) > >> > >> Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.mon...@intel.com> > > Applied, thanks > > It looks like some systems have quite a few devices that report -1 as > numa_node value causing lots of warning messages being printed. > Quick fixes that come to mind would be: > 1) Change log level to DEBUG
As it is important for performance, it should not be just for DEBUG. > 2) Add static var to only print the message once. Yes good idea. > I also think that the message itself should show at least the BDF to at > least know which devices are reporting bad numa_node values. With the static variable, we will have only the first device BDF. Is it relevant?
