> On Jun 21, 2017, at 5:27 AM, Bruce Richardson <bruce.richard...@intel.com> > wrote: > > On Tue, Jun 20, 2017 at 11:21:39PM +0200, Thomas Monjalon wrote: >> If a library or a build tool uses a definition from a driver, >> there is a build ordering issue, like seen when moving PCI code >> into a bus driver. >> >> One option is to keep PCI helpers and some common definitions in EAL. >> The other option is to symlink every headers at the beginning of >> the build so they can be included by any other component. >> >> This patch shows how to achieve the second option. >> >> Signed-off-by: Thomas Monjalon <tho...@monjalon.net> >> --- > > My 2c. > > This may be worth doing, however, two points to consider. > > 1. If we look to change build system this may not be worth doing unless > a compelling need becomes obvious in the short term. In the meantime, > for cases where it is needed... > 2. libraries can already access the includes from drivers or other > places fairly easily, just by adding the relevant "-I" flag to the > CFLAGS for that lib. > > That said, since the work is already done developing this, and if it > doesn't hurt in terms of build time, I suppose we might as well merge > it in. > > So tentative ack from me, subject to testing and feedback from others.
+1, I already have to make sure everything is symlinked first in my private DPDK work for other reasons. This patch would allow me to remove that special code. > > /Bruce Regards, Keith
