21/06/2017 01:29, Gaetan Rivet: > +/** > + * Device comparison function. > + * > + * @param dev > + * Device handle. > + * > + * @param data > + * Data to compare against. > + * > + * @return > + * 0 if the device matches the data. > + * !0 if the device does not match. > + * <0 if ordering is possible and the device is lower than the data. > + * >0 if ordering is possible and the device is greater than the data. > + */ > +typedef int (*rte_dev_cmp_t)(const struct rte_device *dev, const void *data);
data is really abstract. Maybe a comment is missing to explain that data is better specified in bus implementations? Why not implement it for PCI?
