16/06/2017 11:21, Shreyansh Jain: > Hi Bruce, > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > On Fri, Jun 16, 2017 at 11:10:31AM +0530, Shreyansh Jain wrote: > > > From: Hemant Agrawal <hemant.agra...@nxp.com> > > > > > > Bit Swap and LE<=>BE conversions for 23, 40 and 48 bit width > > > > > > Signed-off-by: Hemant Agrawal <hemant.agra...@nxp.com> > > > --- > > > .../common/include/generic/rte_byteorder.h | 78 > > ++++++++++++++++++++++ > > > 1 file changed, 78 insertions(+) > > > > > Are these really common enough for inclusion in an generic EAL file? > > Would they be better being driver specific, so that we don't end up with > > lots of extra byte-swap routines for each possible size used by a > > driver. > > Reasoning was to keep all bit/byte swap at a single place and if it is > useful for others. > > From DPAA perspective, these macro can be anywhere. In case someone else too > has use of this (now or in near-future), probably then we can consider this > in EAL. > Else, if I don't get much responses in a few days, I will shift them to > DPAA driver in next version of this series.
I prefer keeping common functions in a common place. So I like this patch.
