Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, June 14, 2017 10:22 PM
> To: Iremonger, Bernard <bernard.iremon...@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: modify callback process API
>
> Hi,
>
> 12/06/2017 17:18, Bernard Iremonger:
> > Change the rte_eth_dev_callback_process function to return int, and
> > add a void *ret_param parameter.
>
> You should squash tests and examples changes in this change to avoid
> breaking compilation.
> Doc patch can also be squashed.
>
I will squash patches into one patch.
> > --- a/lib/librte_ether/rte_ether_version.map
> > +++ b/lib/librte_ether/rte_ether_version.map
> > +DPDK_17.08 {
> > + global:
> > +
> > + _rte_eth_dev_callback_process;
> > +
> > +} DPDK_17.05;
>
> You should remove the original function from 2.2 ABI block.
I will remove from 2.2 ABI block.
Thanks for the review.
Regards,
Bernard.
