HI, Olivier

> Thank you for your quick answer.
> 
> Yes, the pci probing continues for the other ports even if one port
> failed (since v17.05, commit 10f6c93cea).
> 
> But I find a bit strange to have this check about the SFP in the
> PCI probing function instead of having it the port initialization
> function. My understanding is the SFP check is not related to PCI
> probing. Is it consistent with other drivers?
>
Could your customer help to check what is the exactly error code is by
Checking the "hw->aq.asq_last_status" when eth_i40e_dev_init() fails.

Yes, it seems better PHY init fails doesn't block PCI probe. Just compared with 
i40e
Kernel version, PHY init fails doesn't block CPI probe. And there is watchdog 
task to
Check the PHY status. But DPDK is polling mode, If PCI probe fails, PCI probe 
continues,
then application need poll PHY status to support SFP change.

And I also checked ixgbe driver, it seems phy init is done at probe time.
In my opinion, dev_start and dev_stop is meaning ready for receiving and 
transmitting
packets, it may not be suitable to put it in the start/stop phase.


> 
> Regards
> Olivier

Reply via email to