Hi Ferruh, On Fri, Jun 09, 2017 at 09:56:14AM +0100, Ferruh Yigit wrote: > On 6/8/2017 12:59 AM, Gaetan Rivet wrote: > > Signed-off-by: Gaetan Rivet <gaetan.ri...@6wind.com> > > --- > > config/common_linuxapp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/config/common_linuxapp b/config/common_linuxapp > > index b3cf41b..cc85cc6 100644 > > --- a/config/common_linuxapp > > +++ b/config/common_linuxapp > > @@ -38,7 +38,7 @@ CONFIG_RTE_EXEC_ENV_LINUXAPP=y > > CONFIG_RTE_EAL_IGB_UIO=y > > CONFIG_RTE_EAL_VFIO=y > > CONFIG_RTE_KNI_KMOD=y > > -CONFIG_RTE_LIBRTE_KNI=y > > +CONFIG_RTE_LIBRTE_KNI=n > > CONFIG_RTE_LIBRTE_PMD_KNI=y > > CONFIG_RTE_LIBRTE_VHOST=y > > CONFIG_RTE_LIBRTE_PMD_VHOST=y > > > > Hi Gaetan, > > We shouldn't just disable components that doesn't compile. >
Ah, sure :) . This patch is not meant to be integrated as is, but only as a convenient way for testers to apply the patchset and verify the compilation, as far as KNI is not concerned. Eventdev and cryptodev fixed this dependency. I was thinking about looking into it for KNI and PDUMP but I don't have the time right now, and I'm not sure I will have until the end of June. > And what happens when it is enabled, not compiled at all? So you are > literally breaking the existing support with your patch? > > Thanks, > ferruh > -- Gaëtan Rivet 6WIND
