Hi Jingjing,
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Wednesday, June 07, 2017 10:12 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] app/testpmd: print statistics periodically
>
>
>
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Monday, May 29, 2017 5:39 AM
> > To: Wu, Jingjing <jingjing...@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> <pablo.de.lara.gua...@intel.com>
> > Subject: [PATCH] app/testpmd: print statistics periodically
> >
> > Add parameter to print port statistics periodically
> > (disabled by default), if interactive mode is not enabled.
> >
> > This is useful to allow the user to see port statistics
> > without having to get into the internal command line.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.gua...@intel.com>
> > ---
> > app/test-pmd/parameters.c | 15 ++++++++++++-
> > app/test-pmd/testpmd.c | 40
> > ++++++++++++++++++++++++++++++++++-
> > app/test-pmd/testpmd.h | 1 +
> > doc/guides/testpmd_app_ug/run_app.rst | 5 +++++
> > 4 files changed, 59 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> > index fbe6284..a758b25 100644
> > --- a/app/test-pmd/parameters.c
> > +++ b/app/test-pmd/parameters.c
> > @@ -89,6 +89,7 @@ usage(char* progname)
> > "[--cmdline-file=FILENAME] "
> > #endif
> > "[--help|-h] | [--auto-start|-a] | ["
> > + "-T PERIOD: statistics will be shown every PERIOD seconds (only
> if interactive is
> How about change it following format?
>
> "[--help|-h] | [--auto-start|-a] | [ -T PERIOD] | ["
> "-T PERIOD: statistics will be shown every PERIOD seconds (only if
> interactive is
> "--coremask=COREMASK --portmask=PORTMASK --numa "
>
>
> Add line after printf(" --help: ......
> printf("-T PERIOD: statistics will be shown every PERIOD seconds (only if
> interactive is disabled)\n");
>
Agreed. Will change this, thanks for the review.
Pablo
