> -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Monday, May 29, 2017 5:37 AM > To: Wu, Jingjing <jingjing...@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com> > Subject: [PATCH] app/testpmd: add parameter to start forwarding sending > > Add parameter to start forwarding sending first > a burst of packets, which is useful when testing > a loopback connection. > > This was already implemented as an internal command, > but adding it as a parameter is interesting, as it > allows the user to test a loopback connection without > entering in the internal command line. > > Signed-off-by: Pablo de Lara <pablo.de.lara.gua...@intel.com> > --- > app/test-pmd/parameters.c | 5 +++++ > app/test-pmd/testpmd.c | 5 +++-- > app/test-pmd/testpmd.h | 1 + > doc/guides/testpmd_app_ug/run_app.rst | 4 ++++ > 4 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > index fbe6284..0da4172 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -89,6 +89,7 @@ usage(char* progname) > "[--cmdline-file=FILENAME] " > #endif > "[--help|-h] | [--auto-start|-a] | [" > + "--tx-first"
Just consider about the interactive mode. If using command start, will it still call start_packet_forwarding(0)? And if start tx_first, still call start_packet_forwarding(1)? It may cause confused whether this argu "--tx-first" works. If it only works for non-interactive, you'd better to comment it. Thanks Jingjing
