> -----Original Message----- > From: Lu, Wenzhuo > Sent: Wednesday, June 7, 2017 2:12 PM > To: Xing, Beilei <beilei.x...@intel.com>; Wu, Jingjing <jingjing...@intel.com> > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing > function > > > -----Original Message----- > > From: Xing, Beilei > > Sent: Wednesday, June 7, 2017 2:07 PM > > To: Lu, Wenzhuo; Wu, Jingjing > > Cc: dev@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing > > function > > > > > > > > > -----Original Message----- > > > From: Lu, Wenzhuo > > > Sent: Wednesday, June 7, 2017 1:46 PM > > > To: Xing, Beilei <beilei.x...@intel.com>; Wu, Jingjing > > > <jingjing...@intel.com> > > > Cc: dev@dpdk.org > > > Subject: RE: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing > > > function > > > > > > Hi Beilei, > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > > > > Sent: Thursday, June 1, 2017 2:57 PM > > > > To: Wu, Jingjing > > > > Cc: dev@dpdk.org > > > > Subject: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing > > > > function > > > > > > > > This patch adds NVGRE parsing function to support NVGRE classification. > > > > > > > > Signed-off-by: Beilei Xing <beilei.x...@intel.com> > > > > --- > > > > drivers/net/i40e/i40e_flow.c | 271 > > > > ++++++++++++++++++++++++++++++++++++++++++- > > > > 1 file changed, 269 insertions(+), 2 deletions(-) > > > > > > > > > > + > > > > + break; > > > > + case RTE_FLOW_ITEM_TYPE_VLAN: > > > > + vlan_spec = > > > > + (const struct rte_flow_item_vlan *)item- > > > > >spec; > > > > + vlan_mask = > > > > + (const struct rte_flow_item_vlan *)item- > > > > >mask; > > > > + if (nvgre_flag) { > > > Why need to check nvgre_flag? Seems VLAN must be after NVGRE, so > > > this flag is always 1. > > > > It's used to distinguish outer mac or inner mac. > I know you need to add this flag for MAC. But I'm talking about VLAN. There's > only inner VLAN. So, seems it's useless here.
Oh yes, sorry for misunderstanding, outer vlan is not supported here, it can be removed. Will update in next version.
