On 5/26/2017 7:39 PM, Ajit Khaparde wrote:
> This patch adds code to get and clear VF stats.
> It also adds the necessary HWRM structures to send the command
> to the firmware.
>
> Signed-off-by: Stephen Hurd <stephen.h...@broadcom.com>
> Signed-off-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
>
> --
> v1->v2: regroup related patches and incorporate other review comments
> ---
> drivers/net/bnxt/bnxt_hwrm.c | 38 ++++++++++++++++++
> drivers/net/bnxt/bnxt_hwrm.h | 3 ++
> drivers/net/bnxt/rte_pmd_bnxt.c | 87
> +++++++++++++++++++++++++++++++++++++++++
> drivers/net/bnxt/rte_pmd_bnxt.h | 64 ++++++++++++++++++++++++++++++
> 4 files changed, 192 insertions(+)
It looks like new APIs not added into .map file.
This doesn't cause a build error because they are not used anywhere,
that is why using testpmd to implement them helps to find any issues.
<...>
> +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count)
> +{
> + struct rte_eth_dev *dev;
> + struct rte_eth_dev_info dev_info;
> + struct bnxt *bp;
> +
> + dev = &rte_eth_devices[port];
> + rte_eth_dev_info_get(port, &dev_info);
> + bp = (struct bnxt *)dev->data->dev_private;
> +
> + return bnxt_hwrm_func_qstats_tx_drop(bp, 0xffff, count);
> +}
This function is not to get VF stats from PF. As far as I can see this
just gets queue stats, does this really needs to be PMD specific API,
isn't this something generic?
<...>
