> -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan....@linux.intel.com] > Sent: Wednesday, May 24, 2017 4:43 PM > To: Jens Freimann <jfrei...@redhat.com> > Cc: Wang, Zhihong <zhihong.w...@intel.com>; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count > > On Wed, May 24, 2017 at 10:36:01AM +0200, Jens Freimann wrote: > > On Wed, May 24, 2017 at 04:14:19PM +0800, Yuanhan Liu wrote: > > > On Tue, May 23, 2017 at 12:51:56PM +0000, Wang, Zhihong wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Jens Freimann [mailto:jfrei...@redhat.com] > > > > > Sent: Tuesday, May 23, 2017 7:54 PM > > > > > To: Wang, Zhihong <zhihong.w...@intel.com> > > > > > Cc: dev@dpdk.org; yuanhan....@linux.intel.com > > > > > Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count > > > > > > > > > > On Mon, May 22, 2017 at 04:01:08PM -0400, Zhihong Wang wrote: > > > > > > This patch implements the ops rx_queue_count for vhost PMD by > adding > > > > > > a helper function rte_vhost_rx_queue_count in vhost lib. > > > > > > > > > > > > The ops ops rx_queue_count gets vhost RX queue avail count and > helps > > > > > > > > > > s/ops ops/ops/ ? > > > > > > > > Thanks a lot! > > > > > > Seems you overlooked other comments, such as: > > > > > > > > > + vq = dev->virtqueue[qid]; > > > > > > > > > > check for vq == NULL? > > > > > > > > > > regards, > > > > > Jens > > > > > > Besides, Jens, I'm not a big fan of "dev == NULL" over "!dev". I accept > > > both :) > > > > Personally I'm with you on this, but it says different in > http://dpdk.org/doc/guides/contributing/coding_style.html > > Anyway, up to you :) > > Yes, I know that. To make every body happy, I would suggset you to > follow the coding style. But if you have already choosen another way, > I won't bother to ask you do the change. Unless, it becomes a must > in future.
Thanks Yuanhan and Jens! Will address these comments in v3. > > --yliu
