On Mon, May 22, 2017 at 5:55 AM, Ferruh Yigit <ferruh.yi...@intel.com> wrote:
> On 5/18/2017 2:57 AM, Ajit Khaparde wrote: > > This patchset amongst other changes adds support few more dev_ops, > > updates HWRM to version 1.7.5, switches to polling stats from the > > hardware, support for LRO etc.. > > > > bnxt: add various hwrm input/output structures > > bnxt: code reorg to properly allocate resources in PF/VF modes > > bnxt: add tunneling support > > bnxt: support lack of huge pages > > bnxt: add functions for tx_loopback, set_vf_mac and queues_drop_en > > bnxt: add support for set VF QOS and MAC anti spoof > > bnxt: add support for VLAN stripq, VLAN anti spoof and VLAN filtering > for VFs > > bnxt: add support to get and clear VF specific stats > > bnxt: add code to determine the Rx status of VF > > bnxt: add support to add a VF MAC address > > bnxt: add support for xstats get/reset > > bnxt: Add support for VLAN filter and strip dev_ops > > bnxt: add code to configure a default VF VLAN > > bnxt: add support for set_mc_addr_list and mac_addr_set > > bnxt: add support for fw_version_get dev_op > > bnxt: add support to set MTU > > bnxt: add support for LRO > > bnxt: add rxq_info_get and txq_info_get dev_ops > > bnxt: add additonal HWRM debug info to error messages > > bnxt: reorg the query stats code > > bnxt: update to HWRM version 1.7.5 > > bnxt: Add support to set VF rxmode > > bnxt: add code to support vlan_pvid_set dev_op > > > 25 files changed, 10407 insertions(+), 3036 deletions(-) > > Hi Ajit, > > This is a big patch, and as far as I can see it does mainly three things: > > 1) Update base driver kind of updates (although bnxt doesn't have a base > > folder, there are files we can put into this category). > Since all the hardware specific code is abstracted by the HWRM api , we feel doing a base folder will be pretty much another abstraction above this HWRM. But I will try to break down the bigger patch into smaller ones. Its just that I tried to keep the related code in one patch to keep the functionality together. 2) Add some new driver features. > 3) Add PMD specific APIs mainly to control VF from PF. > > - Is it possible to group patches in the patchset as above, currently > patches are all mixed and harder to understand? > I will do my best. > > - for 3), Some of the PMD specific APIs are common with exiting ones in > i40e and ixgbe, should we extract them into eth_dev_ops now? @Thomas, > any comment? > > - For 2), can you please update features/bnxt.ini file in each patch > that adds a feature, to enable that feature in the document. And finally > a release doc update in separate patch can be good. > Ok. I will work on that. > > - Some commits has function names updated in the patch subject, can you > please update them to describe the feature added, function name detail > can be in commit log. You can use ./devtools/check-git-log.sh to verify > > commit logs, there are some set of errors now. > Sure. > > Thanks, > ferruh >
