On 5/23/2017 4:59 AM, Qi Zhang wrote:
> Add fdir flex byte support for rte_flow APIs.
> 
> Signed-off-by: Qi Zhang <qi.z.zh...@intel.com>

Hi Qi,

There are a few checkpatch errors for this patch also please find a few
minor syntax issues below.

<...>

> +int
> +ixgbe_fdir_set_flexbytes_offset(struct rte_eth_dev *dev,
> +                             uint16_t offset)
> +{
> +     uint32_t fdirctrl;
> +     int i;
> +     struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);

We don't have "reverse christmas tree declarations", right J

<...>

> +
> +             /*Not supported last point for range*/

Spaces around comment.

<...>

> +             /**
> +              * mask should not be null
> +              */

Can have single line comment.

Reply via email to