08/05/2017 21:03, Mody, Rasesh: > Hi Thomas, > > > From: Rasesh Mody [mailto:rasesh.m...@cavium.com] > > Sent: Sunday, May 07, 2017 3:53 PM > > > > With the change in base APIs the logic for 100G handling needs to be > > adjusted to pass cid values instead for queue ids. The current API works > > assuming its queue id. > > > > Fixes: 69d7ba88f1a1 ("net/qede/base: use L2-handles for RSS configuration") > > This is a *CRITICAL MUST FIX* patch for 100Gb adapters supported by qed/qede > on DPDK 17.05. There will be functional and performance issues/regression > without this fix on 100Gb adapters. > > Without this change, RSS in 100Gb adapters do not function properly and leads > to performance issues. Rx Queue stop command on 100Gb adapter will results > in FW exception, where the Rx queue stop request gets stuck in FW and leads > to PMD/application error saying failed to stop RXQ 0. > > The issue was introduced by one of the 17.05 base driver patches > (net/qede/base: use L2-handles for RSS configuration), which has changed the > logic to use queue handles instead of queue ids. However, we missed to make > the corresponding changes in 17.05 QEDE for the 100Gb adapter. This patch > addresses that by making changes in QEDE to work with queue handles and > associate the queues to respective HW functions based on queue handles. > > Please include this fix in 17.05 release.
Applied, thanks This patch is big. So I will wait for compilation tests of the night before releasing.
