[dpdk-dev] [PATCH] proc-info: wrong sizeof argument in malloc function

[Kuba Kozak]

From: Michal Jastrzebski <michalx.k.jastrzeb...@intel.com>

Coverity reported that an argument for sizeof was used improperly. 
We should allocate memory for value size that pointer points to,
instead of pointer size itself. 

Coverity issue: 144523, 144521
Fixes: 7ac16a3660c0 ("app/proc-info: support xstats by ID and by name")

Signed-off-by: Michal Jastrzebski <michalx.k.jastrzeb...@intel.com>
---
 app/proc_info/main.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/proc_info/main.c b/app/proc_info/main.c
index 17a1c87..d4f6a82 100644
--- a/app/proc_info/main.c
+++ b/app/proc_info/main.c
@@ -434,7 +434,7 @@ static void collectd_resolve_cnt_type(char *cnt_type, 
size_t cnt_type_len,
        int ret, i;
        static const char *nic_stats_border = "########################";
 
-       values = malloc(sizeof(values) * len);
+       values = malloc(sizeof(*values) * len);
        if (values == NULL) {
                printf("Cannot allocate memory for xstats\n");
                return;
@@ -486,7 +486,7 @@ static void collectd_resolve_cnt_type(char *cnt_type, 
size_t cnt_type_len,
                printf("Cannot get xstats count\n");
                return;
        }
-       values = malloc(sizeof(values) * len);
+       values = malloc(sizeof(*values) * len);
        if (values == NULL) {
                printf("Cannot allocate memory for xstats\n");
                return;
-- 
1.7.9.5