On Sun, May 7, 2017 at 1:50 PM, Thomas Monjalon <tho...@monjalon.net> wrote:
> Hi, > > 25/04/2017 20:39, Ravi Kerur: > > Merge relevant contents of l3fwd and l3fwd-acl documentation. > > Modify l3fwd document with ACL specific information. > > Remove l3fwd-acl documentation file. > > > > Signed-off-by: Ravi Kerur <rke...@gmail.com> > > --- > > doc/guides/sample_app_ug/img/ipv4_hash_rule.svg | 158 +++++++++ > > doc/guides/sample_app_ug/img/ipv4_lpm_rule.svg | 139 ++++++++ > > doc/guides/sample_app_ug/index.rst | 1 - > > doc/guides/sample_app_ug/l3_forward.rst | 326 > ++++++++++++++++- > > .../sample_app_ug/l3_forward_access_ctrl.rst | 385 > --------------------- > > 5 files changed, 614 insertions(+), 395 deletions(-) > > create mode 100644 doc/guides/sample_app_ug/img/ipv4_hash_rule.svg > > create mode 100644 doc/guides/sample_app_ug/img/ipv4_lpm_rule.svg > > delete mode 100644 doc/guides/sample_app_ug/l3_forward_access_ctrl.rst > > I've not looked at the content. > I just do not understand why a patch for merging content is adding > some new files. > Moreover, these SVG files contains some binary PNG. > Please send only some source files. > Thanks John and Thomas for review. We have created two new ".svg" files illustrating an example for LPM and Exact Match rules and hence they are reflected in the patch. I have created .svg files directly from inkscape and they now contain only html. I have sent 'v2', please review it and let me know if additional changes are required.
