> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wu, Jingjing > Sent: Monday, May 8, 2017 9:02 AM > To: Thomas Monjalon <tho...@monjalon.net>; Dai, Wei <wei....@intel.com> > Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo...@intel.com>; > harish.pa...@cavium.com; rasesh.m...@cavium.com; > stephen.h...@broadcom.com; ajit.khapa...@broadcom.com; Zhang, Helin > <helin.zh...@intel.com>; Ananyev, Konstantin > <konstantin.anan...@intel.com>; Chen, Jing D <jing.d.c...@intel.com>; > adrien.mazarg...@6wind.com; nelio.laranje...@6wind.com; Richardson, Bruce > <bruce.richard...@intel.com>; yuanhan....@linux.intel.com; > maxime.coque...@redhat.com; shepard.sie...@atomicrules.com; > ed.cz...@atomicrules.com; john.mil...@atomicrules.com > Subject: Re: [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to add > many MAC addrs > > > > > -----Original Message----- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Friday, May 5, 2017 10:24 PM > > To: Dai, Wei <wei....@intel.com> > > Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo...@intel.com>; > > harish.pa...@cavium.com; rasesh.m...@cavium.com; > > stephen.h...@broadcom.com; ajit.khapa...@broadcom.com; Zhang, Helin > > <helin.zh...@intel.com>; Ananyev, Konstantin > > <konstantin.anan...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; > > Chen, Jing D <jing.d.c...@intel.com>; adrien.mazarg...@6wind.com; > > nelio.laranje...@6wind.com; Richardson, Bruce > > <bruce.richard...@intel.com>; yuanhan....@linux.intel.com; > > maxime.coque...@redhat.com; shepard.sie...@atomicrules.com; > > ed.cz...@atomicrules.com; john.mil...@atomicrules.com > > Subject: Re: [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to > > add many MAC addrs > > > > 05/05/2017 02:40, Wei Dai: > > > This patch is added to introduce a testpmd command which is used to > > > add more than one MAC addresses one time. > > > This command can simplify the test for the change where the type of > > > return value of adding MAC address. > > > Normally a MAC address may fails to be added only after many MAC > > > addresses have been added. > > > Without this command, a tester may only trigger failed MAC address > > > by running many times of testpmd command 'mac_addr add' . > > > > > > Signed-off-by: Wei Dai <wei....@intel.com> > > > --- > > > app/test-pmd/cmdline.c | 55 > > > ++++++++++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 55 insertions(+) > > > > This patch has not been reviewed. > > It is not a fix and I am not sure it is needed. > > The same doubt, what is this relationship with your fix in Patch 1/3? > If it is only for testing for special case, and it can be done through calling 'mac_addr add' by multi times. I'd like to Nack it.
Thanks Jingjing
