01/05/2017 23:34, Thomas Monjalon:
> I am doing these small changes in your patches:
More explanations below
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -395,7 +395,7 @@ static const struct eth_dev_ops eth_igb_ops = {
> .link_update = eth_igb_link_update,
> .stats_get = eth_igb_stats_get,
> .xstats_get = eth_igb_xstats_get,
> - .xstats_get_by_id = eth_igb_xstats_get_by_id,
> + .xstats_get_by_id = eth_igb_xstats_get_by_id,
> .xstats_get_names_by_id = eth_igb_xstats_get_names_by_id,
> .xstats_get_names = eth_igb_xstats_get_names,
> .stats_reset = eth_igb_stats_reset,
>
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -532,7 +532,7 @@ static const struct eth_dev_ops ixgbe_eth_dev_ops = {
> .link_update = ixgbe_dev_link_update,
> .stats_get = ixgbe_dev_stats_get,
> .xstats_get = ixgbe_dev_xstats_get,
> - .xstats_get_by_id = ixgbe_dev_xstats_get_by_id,
> + .xstats_get_by_id = ixgbe_dev_xstats_get_by_id,
> .stats_reset = ixgbe_dev_stats_reset,
> .xstats_reset = ixgbe_dev_xstats_reset,
> .xstats_get_names = ixgbe_dev_xstats_get_names,
It is just for correct alignment.
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -188,7 +188,7 @@ rte_eth_dev_allocated(const char *name)
> static uint8_t
> rte_eth_dev_find_free_port(void)
> {
> - unsigned int i;
> + unsigned i;
>
> for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
> if (rte_eth_devices[i].state == RTE_ETH_DEV_UNUSED)
It reverts a change you made in ixgbe patch.
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -185,7 +185,6 @@ extern "C" {
> #include "rte_ether.h"
> #include "rte_eth_ctrl.h"
> #include "rte_dev_info.h"
> -#include "rte_compat.h"
>
> struct rte_mbuf;
>
This include is not needed in this new version of xstats.
I will remove also the changes to release notes (API section),
as the API is not modified. They are just additional functions.
