30/04/2017 06:11, Wei Dai: > Current ethdev always stores MAC address even it fails to be added. > Other function may regard the failed MAC address valid and lead to > some errors. So There is a need to check if the addr is added > successfully or not and discard it if it fails. > > In 3rd patch, add a command "add_more_mac_addr port_id base_mac_addr count" > to add more than one MAC address one time. > This command can simplify the test for the first patch. > Normally a MAC address may fails to be added only after many MAC > addresses have been added. > Without this command, a tester may only trigger failed MAC address > by running many times of testpmd command 'mac_addr add' . > > For v4 patch set, have got acknowledgement from > Nelio Laranjeiro <nelio.laranje...@6wind.com> for mlx changes > Yuanhan Liu <yuanhan....@linux.intel.com> for virtio changes
You have not taken the ack from Konstantin, and you have again forgot --in-reply-to, so review is hard. Checkpatch reports: ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files Please make a perfect v6.
