Wednesday, April 19, 2017 1:57 PM, Ferruh Yigit:
> On 4/18/2017 11:22 AM, Shahaf Shuler wrote:
> > With the Enhanced multi packet send addition, the defaults were made
> > in order to get the maximum out of the box performance.
> > Features like tso, don't use the enhanced send, however the defaults
> > are still valid. This cause Tx queue creation to fail.
> >
> > Fixes: aea00c008140 ("net/mlx5: add hardware TSO support")
>
> Can you please confirm the Fixes line, the code modified below added with
> commit [1], and above commit (correct one is: 3f13f8c23a7c) doesn't touch
> those lines?
Well I guess it can be either.
The commit Fixes TSO because [1] caused TSO to fail on some cases.
The commit Fixes multi-packet send since it is the one which caused the fault.
Since you pointed that out, I guess other will follow your logic as well. So
let's take you suggestion.
Do you need me to post a v3?
>
> [1]
> Fixes: 6ce84bd88919 ("net/mlx5: add enhanced multi-packet send for
> ConnectX-5")
