> On Apr 11, 2017, at 8:39 AM, Yigit, Ferruh <ferruh.yi...@intel.com> wrote:
>
> On 4/11/2017 2:23 PM, Wiles, Keith wrote:
>>
>>> On Apr 11, 2017, at 2:18 AM, Pascal Mazon <pascal.ma...@6wind.com> wrote:
>>>
>>> Hi Keith,
>>>
>>> I have a few comments on your patch, see inline.
>>>
>>> On Mon, 10 Apr 2017 13:18:50 -0500
>>> Keith Wiles <keith.wi...@intel.com> wrote:
>>>
>>>> Support for a fixed MAC address for testing with the last octet
>>>> incrementing by one for each interface defined with the new 'mac=fixed'
>>>> string on the --vdev option. The default option is still to randomize
>>>> the MAC address for each tap interface.
>>>>
>>>> Signed-off-by: Keith Wiles <keith.wi...@intel.com>
>
> <...>
>
>>>> +
>>>> +#ifdef IFF_MULTI_QUEUE
>>>> +#define RTE_PMD_TAP_MAX_QUEUES 16
>>>> +#else
>>>> +#define RTE_PMD_TAP_MAX_QUEUES 1
>>>> +#endif
>>>
>>> Remove this IFF_MULTI_QUEUE definition as it is done in rte_eth_tap.h now
>>> (needed for pmd_internals).
>>
>> This should have been removed in your patch
>
> That is already done, and patch is in main repo:
> Fixes: 947d949de7de ("net/tap: fix max queues redefinition")
>
>> and now that Ferruh wants you to submit a patch for the string at the bottom
>> of the PMD, can you remove it?
>
> Pascal already send the patch and it is in next-net now:
> Fixes: f0e5085f4677 ("net/tap: update driver param string")
>
>>
>> I can do both in my patch, but Ferruh and you need to agree before I can
>> submit my patch.
>
> There is no more updated expected, using latest next-net should be OK to
> submit your patch.
OK
>
> Thanks,
> ferruh
Regards,
Keith
