2017-04-06 02:57, Zhao1, Wei: > > /** > > > + * Reset an ethernet device when it's not working. One scenario is, > > > + after PF > > > + * port is down and up, the related VF port should be reset. > > > + * The API will stop the port, clear the rx/tx queues, re-setup the > > > + rx/tx > > > + * queues, restart the port. > > > > s/The API/This function/ > > > > Please explain exactly the responsibility of this function, and how it is > > different from calling stop/configure/start. > > In this reset feature, reset function can do the calling stop/configure/start > process, but also > It can also do some restore work for the port, for example, it can restore > the added parameters > of vlan, mac_addrs, promisc_unicast_enabled falg and > promisc_multicast_enabled flag. > Maybe , I should add this explanation in the patch comments or function > comments?
Yes it must be explain in the doxygen part of the function.
