On 04/04/2017 01:50 PM, Markos Chandras wrote: > Hi Nirmoy, > > On 04/04/2017 01:32 PM, Nirmoy Das wrote: >> fixes: >> error: In the GNU C Library, "makedev" is defined >> by <sys/sysmacros.h>. For historical compatibility, it is >> currently defined by <sys/types.h> as well, but we plan to >> remove this soon. To use "makedev", include <sys/sysmacros.h> >> directly. If you did not intend to use a system-defined macro >> "makedev", you should undefine it after including <sys/types.h>. [-Werror] >> dev = makedev(major, minor); >> > > You forgot the 'Signed-off-by' line which is required for patches. > > See doc/guides/contributing/patches.rst >
Ah never mind I just saw v2. -- markos SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
