Let's remind the obvious:
a patch must never break the compilation of any area of code
It happens to have some break with some kernels or architectures,
but it should be an exception and fixed quickly when it is discovered.
I am seeing more and more patches which cannot be applied because of
obvious compilation issues. It makes loosing time to everyone.
If you are not sure how to test the compilation,
devtools/test-build.sh is the recommended tool.
It can be configured in ~/.config/dpdk/devel.config
to adapt the options to your environment.
Example for x86 compilation:
if echo $DPDK_TARGET | grep -q '^i686' ; then
export DPDK_DEP_ARCHIVE=y
export DPDK_DEP_ZLIB=y
export DPDK_DEP_PCAP=y
export DPDK_DEP_SSL=y
export DPDK_DEP_MOFED=y
export DPDK_DEP_CFLAGS="-I$mlxdep/include"
export DPDK_DEP_LDFLAGS="-L$mlxdep/lib32"
export LIBSSO_SNOW3G_PATH=$root/libsso/libsso32-snow3g-0.3.1
export PQOS_INSTALL_PATH=$root/libqos/install/lib32
elif echo $DPDK_TARGET | grep -q '^x86_64' ; then
export DPDK_DEP_ARCHIVE=y
export DPDK_DEP_ZLIB=y
export DPDK_DEP_PCAP=y
export DPDK_DEP_SSL=y
export DPDK_DEP_MOFED=y
export DPDK_DEP_NUMA=y
export DPDK_DEP_SZE=y
export DPDK_DEP_ISAL_CRYPTO=y
export DPDK_DEP_CFLAGS="-I$mlxdep/include -I$szedep/include"
export DPDK_DEP_LDFLAGS="-L$mlxdep/lib -L$szedep/lib64 -rpath=$szedep/lib64"
export AESNI_MULTI_BUFFER_LIB_PATH=$root/aesni/intel-ipsec-mb
export LIBSSO_SNOW3G_PATH=$root/libsso/libsso-snow3g-0.3.1
export LIBSSO_KASUMI_PATH=$root/libsso/libsso-kasumi-0.3.1
export LIBSSO_ZUC_PATH=$root/libsso/libsso-zuc-0.1.1
export PQOS_INSTALL_PATH=$root/libqos/install/lib
fi
export DPDK_BUILD_TEST_CONFIGS='x86_64-native-linuxapp-clang+shared+next+debug
i686-native-linuxapp-gcc+default'
You are also welcome to add some automatic checks in the distributed CI,
which will be shown in patchwork.
Thanks for your attention
