> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Sunday, April 2, 2017 3:57 PM > To: Van Haaren, Harry <harry.van.haa...@intel.com> > Cc: dev@dpdk.org; Richardson, Bruce <bruce.richard...@intel.com>; Hunt, David > <david.h...@intel.com> > Subject: Re: [PATCH v7 17/22] test/eventdev: add SW tests for load balancing > > On Thu, Mar 30, 2017 at 08:30:45PM +0100, Harry van Haaren wrote: > > This commit adds various tests for load-balancing and > > queue prioritization. > > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > > Signed-off-by: David Hunt <david.h...@intel.com> > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > > > > Acked-by: Anatoly Burakov <anatoly.bura...@intel.com> > > > Hi Harry, > > I got following build error on FreeBSD + gcc 4.9.4 combo. > > $ gcc -v > Using built-in specs. > COLLECT_GCC=gcc > COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc49/gcc/x86_64-portbld-freebsd10.3/4.9.4/lto-wrapper > Target: x86_64-portbld-freebsd10.3 > Configured with: /wrkdirs/usr/ports/lang/gcc/work/gcc-4.9.4/configure > --disable-bootstrap --disable-nls --enable-gnu-indirect-function > --libdir=/usr/local/lib/gcc49 --libexecdir=/usr/local/libexec/gcc49 > --program-suffix=49 --with-as=/usr/local/bin/as --with-gmp=/usr/local > --with-gxx-include-dir=/usr/local/lib/gcc49/include/c++/ > --with-ld=/usr/local/bin/ld --with-pkgversion='FreeBSD Ports Collection' > --with-system-zlib --with-ecj-jar=/usr/local/share/java/ecj-4.5.jar > --enable-languages=c,c++,objc,fortran,java --prefix=/usr/local > --localstatedir=/var --mandir=/usr/local/man > --infodir=/usr/local/info/gcc49 --build=x86_64-portbld-freebsd10.3 > Thread model: posix > gcc version 4.9.4 (FreeBSD Ports Collection) > $ > > I think it is nothing do with FreeBSD. Looks like gcc < 5 will hit this > issue. But the strange part is patchwork test report shows as compilation > success. > > http://dpdk.org/ml/archives/test-report/2017-April/017005.html
Can't reproduce with linux and gcc 4.8.5 here, <snip compile error log> > If you don't have any better fix, I can apply the following on pull > request. If you have something better send it as patch. > > $ git diff > diff --git a/test/test/Makefile b/test/test/Makefile > index ac802e1d..104532d 100644 > --- a/test/test/Makefile > +++ b/test/test/Makefile > @@ -218,6 +218,11 @@ ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo > 1), 1) > CFLAGS_test_memcpy.o += -fno-var-tracking-assignments > CFLAGS_test_memcpy_perf.o += -fno-var-tracking-assignments > endif > +# for older GCC versions, allow us to initialize an event using > +# designated initializers. > +ifeq ($(shell test $(GCC_VERSION) -le 50 && echo 1), 1) > +CFLAGS_test_eventdev_sw.o += -Wno-missing-field-initializers > +endif > endif Thanks for investigating fix for this Jerin, please apply above yes; Acked-by: Harry van Haaren <harry.van.haa...@intel.com>