Hi Ferruh,
> -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, March 31, 2017 5:53 PM > To: Iremonger, Bernard <bernard.iremon...@intel.com>; dev@dpdk.org; > Xing, Beilei <beilei.x...@intel.com>; Wu, Jingjing <jingjing...@intel.com> > Cc: Zhang, Helin <helin.zh...@intel.com>; Lu, Wenzhuo > <wenzhuo...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v6 0/5] net/i40e: QinQ filter > > On 3/31/2017 4:18 PM, Bernard Iremonger wrote: > > It adds support for QinQ filters. > > It uses the replace filter Admin Queue command. > > > > Changes in v6: > > Rebase to latest dpdk-next-net. > > Fix checkpatch warnings. > > > > Changes in v5: > > Rebase to latest dpdk-next-net. > > Rebase patches 2 and 3 following comments. > > Uses map_5.88 firmware. > > > > Changes in v4: > > Reordered patches following comments. > > Revises patches 2 and 3 following comments. > > > > Changes in v3: > > Rebase to latest dpdk-next-net. > > Revised patches 1-3 following comments. > > Added patches 4 and 5. > > > > Changes in v2: > > Rebase to latest dpdk-next-net. > > Reordered patches, and reduced from 4 to 3 patches. > > > > Bernard Iremonger (5): > > net/i40e: initialise L3 MAP register > > net/i40e: add QinQ filter create function > > net/i40e: parse QinQ pattern > > net/i40e: update destroy tunnel filter function > > net/i40e: update tunnel filter restore function > > Still getting some long-line checkpatch warnings [1], can you please check > them? > > Thanks, > ferruh > > [1] > WARNING:LONG_LINE: line over 80 characters > #46: FILE: drivers/net/i40e/i40e_ethdev.c:1136: > + ret = i40e_aq_debug_write_register(hw, I40E_GLQF_L3_MAP(40), > 0x00000028, NULL); > > WARNING:LONG_LINE: line over 80 characters > #144: FILE: drivers/net/i40e/i40e_ethdev.c:12363: > + filter_replace.old_filter_type = > I40E_AQC_REPLACE_CLOUD_CMD_INPUT_FV_STAG_IVLAN; > > WARNING:LONG_LINE: line over 80 characters > #150: FILE: drivers/net/i40e/i40e_ethdev.c:12369: > + filter_replace_buf.data[0] |= > I40E_AQC_REPLACE_CLOUD_CMD_INPUT_VALIDATED; > > WARNING:LONG_LINE: line over 80 characters > #154: FILE: drivers/net/i40e/i40e_ethdev.c:12373: > + filter_replace_buf.data[4] = > I40E_AQC_REPLACE_CLOUD_CMD_INPUT_FV_INNER_VLAN; > > WARNING:LONG_LINE: line over 80 characters > #155: FILE: drivers/net/i40e/i40e_ethdev.c:12374: > + filter_replace_buf.data[4] |= > I40E_AQC_REPLACE_CLOUD_CMD_INPUT_VALIDATED; > > WARNING:LONG_LINE: line over 80 characters > #159: FILE: drivers/net/i40e/i40e_ethdev.c:12378: > + ret = i40e_aq_replace_cloud_filters(hw, &filter_replace, > &filter_replace_buf); > > WARNING:LONG_LINE: line over 80 characters > #176: FILE: drivers/net/i40e/i40e_ethdev.c:12395: > + filter_replace_buf.data[0] |= > I40E_AQC_REPLACE_CLOUD_CMD_INPUT_VALIDATED; > > WARNING:LONG_LINE: line over 80 characters > #178: FILE: drivers/net/i40e/i40e_ethdev.c:12397: > + filter_replace_buf.data[4] |= > I40E_AQC_REPLACE_CLOUD_CMD_INPUT_VALIDATED; > > WARNING:LONG_LINE: line over 80 characters > #179: FILE: drivers/net/i40e/i40e_ethdev.c:12398: > + ret = i40e_aq_replace_cloud_filters(hw, &filter_replace, > &filter_replace_buf); The checkpatch script is allowing lines up to 90 characters now. Previously long lines were acceptable . Regards, Bernard.
