Hi, > On Mar 30, 2017, at 1:06 AM, Shahaf Shuler <shah...@mellanox.com> wrote: > > Since mlx5 PMD data path is on top of PRM, such verbs calls are > no longer needed. > > Signed-off-by: Shahaf Shuler <shah...@mellanox.com> > Acked-by: Nelio Laranjeiro <nelio.laranje...@6wind.com>
Acked-by: Yongseok Koh <ys...@mellanox.com> I ack the code change but one small suggestion regarding the commit header. It looks like 'if' means interface, 'rd' means the Resource Domain, and 'qp' means the Queue Pair. which are all mellanox specific terms and acronyms. My suggestion is: net/mlx5: remove unnecessary Verbs library calls And how about moving the details into the message body: Remove unnecessary interface queries and the Resource Domain when creating the Queue Pair. Since mlx5 PMD data path is on top of native APIs, such Verbs library calls are no longer needed. Thanks, Yongseok
