2017-03-20 16:04, Yongseok Koh:
> In rte_eth_check_reta_mask(), it is required to align the size of the RETA
> table to RTE_RETA_GROUP_SIZE but as the size can be less than the limit,
> this should be removed. The change is also applied to a command of testpmd.
> 
> Signed-off-by: Yongseok Koh <ys...@mellanox.com>
[...]
> -     if (reta_size != RTE_ALIGN(reta_size, RTE_RETA_GROUP_SIZE)) {
> -             RTE_PMD_DEBUG_TRACE("Invalid reta size, should be %u aligned\n",
> -                                                     RTE_RETA_GROUP_SIZE);
> -             return -EINVAL;
> -     }
> -
> -     num = reta_size / RTE_RETA_GROUP_SIZE;
> +     num = (reta_size + RTE_RETA_GROUP_SIZE - 1) / RTE_RETA_GROUP_SIZE;

There is no comment for this constraint neither in the code nor in the
commit: http://dpdk.org/commit/66c594904
So, I guess it can be removed.
If a check is needed, it could be added in the relevant drivers.

Helin, Konstantin, please check for Intel drivers.

Ferruh, please take care of this series.

Reply via email to