> -----Original Message----- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, March 29, 2017 11:45 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: Re: [PATCH v6 04/13] crypto/dpaa2_sec: add basic crypto > operations > > On 3/27/2017 7:28 PM, De Lara Guarch, Pablo wrote: > > > > > >> -----Original Message----- > >> From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] > >> Sent: Friday, March 24, 2017 9:58 PM > >> To: dev@dpdk.org > >> Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, > Pablo; > >> Mcnamara, John; nhor...@tuxdriver.com; hemant.agra...@nxp.com; > >> Akhil Goyal > >> Subject: [PATCH v6 04/13] crypto/dpaa2_sec: add basic crypto > operations > >> > >> From: Akhil Goyal <akhil.go...@nxp.com> > >> > >> Signed-off-by: Hemant Agrawal <hemant.agra...@nxp.com> > >> Signed-off-by: Akhil Goyal <akhil.go...@nxp.com> > >> --- > >> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 181 > >> ++++++++++++++++++++++++++++ > >> 1 file changed, 181 insertions(+) > >> > >> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > >> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > >> index 378df4a..aa08922 100644 > > > > ... > > > >> + > >> +static int > >> +dpaa2_sec_dev_configure(struct rte_cryptodev *dev __rte_unused) > >> +{ > >> + PMD_INIT_FUNC_TRACE(); > >> + > >> + return -ENOTSUP; > >> +} > >> + > > > > There have been an API change here, so this configure function has > another parameter, "struct rte_cryptodev_config". > > > > If you need to send another version, make the change (rebase against > latest subtree). If not, I will make the change for you. > > > > Thanks, > > Pablo > > > > > There is nothing pending from my side for this patch set. Please let me > know if there are any more comments.
Hi Akhil, I am waiting for the network drivers to be applied in mainline, as your patchset depends on the dpaa2 network driver. Thanks, Pablo > > Regards, > Akhil
