> -----Original Message----- > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Wednesday, March 29, 2017 5:31 AM
<...> > > +#define CFG_FLAG_EMPTY_VALUES (1 << 1) > > /**@} */ > > > > I suggest we group all these flags into an (unnamed?) enum in rte_cfgfile.h > rather than macros. Ok. Will do. > > Can we please add a test to validate that error is triggered for empty key > values in the case the CFG_FLAG_EMPTY_VALUES is NOT provided to > rte_cfgfile_load()? Already included. See test_cfgfile_invalid_key_value_pair().
