On 3/28/2017 10:18 PM, Mody, Rasesh wrote: >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Tuesday, March 28, 2017 4:23 AM >> >> On 3/28/2017 7:52 AM, Rasesh Mody wrote: >>> Revise tunnel APIs/structs. >>> - Unite tunnel start and update params in single struct >>> "ecore_tunnel_info" >>> - Remove A0 chip tunnelling support. >>> - Added per tunnel info - removed bitmasks. >>> >>> Signed-off-by: Rasesh Mody <rasesh.m...@cavium.com> >> >> I hate to say this, but this patch gives build error with clang [1], it >> seems it is >> fixed in next patch. > > We also observed this error on clang, however, the fix got wrongly applied to > the next patch, sorry about that. > >> >> This patchset is big, and takes time to review / validate it, and a small >> error >> requires whole patchset done again. I am not suggesting updating this one, >> but for further patchsets, what do you think making multiple smaller >> patchsets? > > Please let us know if we need to refresh the current v4 patchset to address > the clang issue.
Yes, can you please send a new version of the patchset. > It's good suggestion, for further patchsets, we can do multiple smaller > patchsets. > > Thanks! > -Rasesh > >> >> Thanks, >> ferruh >> >> >> [1] >> Building x86_64-native-linuxapp-clang ... >> .../drivers/net/qede/base/ecore_sp_commands.c:141:25: error: implicit >> conversion from enumeration type 'enum tunnel_clss' to different >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] >> p_tun->vxlan.tun_cls = type; >> ~ ^~~~ >> .../drivers/net/qede/base/ecore_sp_commands.c:143:26: error: implicit >> conversion from enumeration type 'enum tunnel_clss' to different >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] >> p_tun->l2_gre.tun_cls = type; >> ~ ^~~~ >> .../drivers/net/qede/base/ecore_sp_commands.c:145:26: error: implicit >> conversion from enumeration type 'enum tunnel_clss' to different >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] >> p_tun->ip_gre.tun_cls = type; >> ~ ^~~~ >> .../drivers/net/qede/base/ecore_sp_commands.c:147:29: error: implicit >> conversion from enumeration type 'enum tunnel_clss' to different >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] >> p_tun->l2_geneve.tun_cls = type; >> ~ ^~~~ >> .../drivers/net/qede/base/ecore_sp_commands.c:149:29: error: implicit >> conversion from enumeration type 'enum tunnel_clss' to different >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] >> p_tun->ip_geneve.tun_cls = type; >> ~ ^~~~ >> 5 errors generated. >> make[10]: *** [base/ecore_sp_commands.o] Error 1 >> make[10]: *** Waiting for unfinished jobs.... >> .../drivers/net/qede/qede_ethdev.c:1724:45: error: variable 'p_tunn' is >> uninitialized when used here [-Werror,-Wuninitialized] >> rc = ecore_sp_pf_update_tunn_cfg(p_hwfn, p_tunn, >> ^~~~~~ >> .../drivers/net/qede/qede_ethdev.c:1711:34: note: initialize the variable >> 'p_tunn' to silence this warning >> struct ecore_tunnel_info *p_tunn; >> ^ >> = NULL >> .../drivers/net/qede/qede_ethdev.c:1877:5: error: variable 'p_tunn' is >> uninitialized when used here [-Werror,-Wuninitialized] >> p_tunn, ECORE_SPQ_MODE_CB, NULL); >> ^~~~~~ >> .../drivers/net/qede/qede_ethdev.c:1822:34: note: initialize the variable >> 'p_tunn' to silence this warning >> struct ecore_tunnel_info *p_tunn; >> ^ >> = NULL >> 2 errors generated. >
