Great, thx, Anatoly.
> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Tuesday, March 28, 2017 5:00 PM
> To: Xu, Qian Q <qian.q...@intel.com>; gowrishanka...@linux.vnet.ibm.com;
> dev@dpdk.org
> Cc: Lu, PeipeiX <peipeix...@intel.com>; Gilmore, Walter E
> <walter.e.gilm...@intel.com>; Jain, Deepak K <deepak.k.j...@intel.com>;
> Richardson, Bruce <bruce.richard...@intel.com>
> Subject: RE: [dpdk-dev] Pls help check <DPDK build error> on old kernel
>
> Hi Qian,
>
> The fix patch is already at v2 (by me, and will receive a v3 due to compile
> failures
> on arm). We're working on fixing this :)
>
> Thanks,
> Anatoly
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xu, Qian Q
> > Sent: Tuesday, March 28, 2017 4:16 AM
> > To: gowrishanka...@linux.vnet.ibm.com; dev@dpdk.org
> > Cc: Lu, PeipeiX <peipeix...@intel.com>; Gilmore, Walter E
> > <walter.e.gilm...@intel.com>; Jain, Deepak K
> > <deepak.k.j...@intel.com>; Richardson, Bruce
> > <bruce.richard...@intel.com>
> > Subject: [dpdk-dev] Pls help check <DPDK build error> on old kernel
> >
> > Hi, Gowrishankar Muthukrishnan
> >
> >
> >
> > Could you help check below build error? On some old kernels, the build
> > failed due to your patch. Thx.
> >
> >
> >
> >
> >
> > There's build error on old kernels which was brought by commit
> > "0fe9830b53452a6747cae9ff1a6bfc737b839a9d":
> >
> > > commit 0fe9830b53452a6747cae9ff1a6bfc737b839a9d
> > > Author: Gowrishankar Muthukrishnan
> > <gowrishanka...@linux.vnet.ibm.com>
> > > Date: Mon Mar 6 20:34:15 2017 +0530
> > >
> > > eal/ppc: support sPAPR IOMMU for vfio-pci
> > >
> > > Below changes adds pci probing support for vfio-pci devices in power8.
> > >
> > Signed-off-by: Gowrishankar Muthukrishnan
> > > <gowrishanka...@linux.vnet.ibm.com>
> > > Acked-by: Anatoly Burakov <anatoly.bura...@intel.com>
> > > Acked-by: Chao Zhu <chao...@linux.vnet.ibm.com>
> >
> > It missed a vfio_iommu_spapr_tce_info structure in conditional define
> > for older kernels, so it breaks compile on those kernels
> >
> > Detail build error logs please refer to below:
> >
> > > Last commit Time : Sun Mar 19 23:13:50 2017 +0100 Last Author :
> > > David Marchand Last commit Hash :
> > 84aac97b49994be6b461b46be160b47938e697b3
> > > Last comment : maintainers: resign from eal maintenance
> > >
> > > Build Summary : 43 Builds Done, 37 Successful, 6 Failures.
> > >
> > > Failure details :
> > >
> > > Failure #1
> > > SUSE12SP3_64 / Linux 3.7.10-1 / GCC 4.7.2 login command: sshpass -p
> > > P@ssw0rd123 ssh root@10.239.69.116
> > > Config: x86_64-native-linuxapp-gcc
> > > CONFIG_RTE_LIBRTE_PMD_PCAP=y,
> > > CONFIG_RTE_NIC_BYPASS=y,
> > > CONFIG_RTE_BUILD_SHARED_LIB=y,
> > > CONFIG_RTE_LIBRTE_VHOST=y,
> > > CONFIG_RTE_LIBRTE_PMD_QAT=y,
> > > CONFIG_RTE_LIBRTE_PMD_AESNI_GCM=y,
> > > CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y
> > >
> > > /homeDPDK/lib/librte_eal/linuxapp/eal/eal_vfio.c: In function
> > > 'vfio_spapr_dma_map':
> > > /homeDPDK/lib/librte_eal/linuxapp/eal/eal_vfio.c:555:9: error:
> > > variable
> > 'info'
> > > has initializer but incomplete type compilation terminated due to
> > > -Wfatal-
> > errors.
> > >
> > > Failure #2
> > > SUSE12SP3_64 / Linux 3.7.10-1 / ICC 16.0.2 login command: sshpass -p
> > > P@ssw0rd123 ssh root@10.239.69.116
> > > Config: x86_64-native-linuxapp-icc
> > > CONFIG_RTE_LIBRTE_PMD_PCAP=y,
> > > CONFIG_RTE_NIC_BYPASS=y,
> > > CONFIG_RTE_BUILD_SHARED_LIB=y,
> > > CONFIG_RTE_LIBRTE_VHOST=y,
> > > CONFIG_RTE_LIBRTE_PMD_QAT=y,
> > > CONFIG_RTE_LIBRTE_PMD_AESNI_GCM=y,
> > > CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y
> > >
> > > /homeDPDK/lib/librte_eal/linuxapp/eal/eal_vfio.c: In function
> > > 'vfio_spapr_dma_map':
> > > /homeDPDK/lib/librte_eal/linuxapp/eal/eal_vfio.c:555:9: error:
> > > variable
> > 'info'
> > > has initializer but incomplete type compilation terminated due to
> > > -Wfatal-
> > errors.
> > >
> > > Failure #3
> > > FC18_64 / Linux 3.6.10-4 / GCC 4.7.2 login command: sshpass -p
> > > P@ssw0rd123 ssh root@10.239.69.131
> > > Config: x86_64-native-linuxapp-gcc
> > > CONFIG_RTE_LIBRTE_PMD_PCAP=y,
> > > CONFIG_RTE_NIC_BYPASS=y,
> > > CONFIG_RTE_BUILD_SHARED_LIB=y,
> > > CONFIG_RTE_LIBRTE_VHOST=y,
> > > CONFIG_RTE_LIBRTE_PMD_QAT=y,
> > > CONFIG_RTE_LIBRTE_PMD_AESNI_GCM=y,
> > > CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y
> > >
> > > DPDK/lib/librte_eal/linuxapp/eal/eal_vfio.c: In function
> > 'vfio_spapr_dma_map':
> > > DPDK/lib/librte_eal/linuxapp/eal/eal_vfio.c:555:9: error: variable
> > > 'info' has initializer but incomplete type compilation terminated
> > > due to -
> > Wfatal-errors.
> > >
> > > Failure #4
> > > FC18_64 / Linux 3.6.10-4 / ICC 14.0.0 login command: sshpass -p
> > > P@ssw0rd123 ssh root@10.239.69.131
> > > Config: x86_64-native-linuxapp-icc
> > > CONFIG_RTE_LIBRTE_PMD_PCAP=y,
> > > CONFIG_RTE_NIC_BYPASS=y,
> > > CONFIG_RTE_BUILD_SHARED_LIB=y,
> > > CONFIG_RTE_LIBRTE_VHOST=y,
> > > CONFIG_RTE_LIBRTE_PMD_QAT=y,
> > > CONFIG_RTE_LIBRTE_PMD_AESNI_GCM=y,
> > > CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y
> > >
> > > DPDK/lib/librte_eal/linuxapp/eal/eal_vfio.c: In function
> > 'vfio_spapr_dma_map':
> > > DPDK/lib/librte_eal/linuxapp/eal/eal_vfio.c:555:9: error: variable
> > > 'info' has initializer but incomplete type compilation terminated
> > > due to -
> > Wfatal-errors.
> > >
> > > Failure #5
> > > RHEL70_64 / Linux 3.10.0-123 / GCC 4.8.5 login command: sshpass -p
> > > P@ssw0rd123 ssh root@10.239.68.173
> > > Config: x86_64-native-linuxapp-gcc
> > > CONFIG_RTE_LIBRTE_PMD_PCAP=y,
> > > CONFIG_RTE_NIC_BYPASS=y,
> > > CONFIG_RTE_BUILD_SHARED_LIB=y,
> > > CONFIG_RTE_LIBRTE_VHOST=y,
> > > CONFIG_RTE_LIBRTE_PMD_QAT=y,
> > > CONFIG_RTE_LIBRTE_PMD_AESNI_GCM=y,
> > > CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y
> > >
> > > DPDK/lib/librte_eal/linuxapp/eal/eal_vfio.c: In function
> > 'vfio_spapr_dma_map':
> > > DPDK/lib/librte_eal/linuxapp/eal/eal_vfio.c:555:9: error: variable
> > > 'info' has initializer but incomplete type struct
> > > vfio_iommu_spapr_tce_info info = { ^ compilation terminated due to
> > > -Wfatal-errors.
> > >
> > > Failure #6
> > > RHEL70_64 / Linux 3.10.0-123 / ICC 14.0.0 login command: sshpass -p
> > > P@ssw0rd123 ssh root@10.239.68.173
> > > Config: x86_64-native-linuxapp-icc
> > > CONFIG_RTE_LIBRTE_PMD_PCAP=y,
> > > CONFIG_RTE_NIC_BYPASS=y,
> > > CONFIG_RTE_BUILD_SHARED_LIB=y,
> > > CONFIG_RTE_LIBRTE_VHOST=y,
> > > CONFIG_RTE_LIBRTE_PMD_QAT=y,
> > > CONFIG_RTE_LIBRTE_PMD_AESNI_GCM=y,
> > > CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y
> > >
> > > DPDK/lib/librte_eal/linuxapp/eal/eal_vfio.c: In function
> > 'vfio_spapr_dma_map':
> > > DPDK/lib/librte_eal/linuxapp/eal/eal_vfio.c:555:9: error: variable
> > > 'info' has initializer but incomplete type struct
> > > vfio_iommu_spapr_tce_info info = { ^ compilation terminated due to
> > > -Wfatal-errors.
> > >
