> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, March 24, 2017 4:59 AM > > On 3/18/2017 7:06 AM, Rasesh Mody wrote: > > From: Harish Patil <harish.pa...@qlogic.com> > > > > This patch includes slowpath configuration and fastpath changes to > > support LRO and TSO. A bit of revamping is needed in order to make use > > of existing packet classification schemes in Rx fastpath and for SG > > element processing in Tx. > > > > Signed-off-by: Harish Patil <harish.pa...@qlogic.com> > > This patch is giving following checkpatch errors [1], I can see the reason of > the multiline dereference is to fit into 80 column line limit, and those > lines are > not easy to escape from line limit. > > But eventually if we get a checkpatch warning, I prefer it to be from long > line, > multiline dereference makes code harder to read. > > What do you think?
Will try to address this more efficiently. > > > [1] > WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - > prefer 'cqe_start_tpa->len_on_first_bd' > #450: FILE: drivers/net/qede/qede_rxtx.c:1045: > + rte_le_to_cpu_16(cqe_start_tpa-> > + len_on_first_bd), > > WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - > prefer 'cqe_start_tpa->ext_bd_len_list[0]' > #453: FILE: drivers/net/qede/qede_rxtx.c:1048: > + rte_le_to_cpu_16(cqe_start_tpa-> > + > + ext_bd_len_list[0]), > > WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - > prefer 'rxq->tpa_info[cqe->fast_path_tpa_end.tpa_agg_index].mbuf' > #465: FILE: drivers/net/qede/qede_rxtx.c:1060: > + rx_mb = rxq-> > + > + tpa_info[cqe->fast_path_tpa_end.tpa_agg_index].mbuf; > > WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - > prefer 'cqe_start_tpa->pars_flags.flags' > #512: FILE: drivers/net/qede/qede_rxtx.c:1087: > + parse_flag = rte_le_to_cpu_16(cqe_start_tpa-> > + > + pars_flags.flags); > > WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - > prefer 'cqe_start_tpa->tunnel_pars_flags.flags' > #541: FILE: drivers/net/qede/qede_rxtx.c:1108: > + tunn_parse_flag = > + cqe_start_tpa-> > + > tunnel_pars_flags.flags; > > WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - > prefer 'fp_cqe->tunnel_pars_flags.flags' > #544: FILE: drivers/net/qede/qede_rxtx.c:1111: > + tunn_parse_flag = fp_cqe-> > + > tunnel_pars_flags.flags; > > > <...>
