Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, March 24, 2017 4:01 AM > > On 3/24/2017 7:28 AM, Rasesh Mody wrote: > > New driver/management fw load request sequence for handling previous > > driver unload. > > > > Signed-off-by: Rasesh Mody <rasesh.m...@cavium.com> > > Hi Rasesh, > > Patch by patch build broken with this patch with following build error, and > fixed back with patch 50/61: > > .../drivers/net/qede/base/ecore_mcp.c:624:2: error: signed shift result > (0xF00000000) requires 37 bits to represent, but 'int' only has 32 bits [- > Werror,-Wshift-overflow] > ECORE_MFW_SET_FIELD(p_load_req->misc0, LOAD_REQ_FORCE, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > .../drivers/net/qede/base/ecore.h:107:31: note: expanded from macro > 'ECORE_MFW_SET_FIELD' > (name) &= ~((field ## _MASK) << (field ## _SHIFT)); \ > ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~ > .../drivers/net/qede/base/ecore_mcp.c:626:2: error: signed shift result > (0xF0000000000) requires 45 bits to represent, but 'int' only has 32 bits [- > Werror,-Wshift-overflow] > ECORE_MFW_SET_FIELD(p_load_req->misc0, LOAD_REQ_FLAGS0, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > .../drivers/net/qede/base/ecore.h:107:31: note: expanded from macro > 'ECORE_MFW_SET_FIELD' > (name) &= ~((field ## _MASK) << (field ## _SHIFT)); \ > ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~ <...> We observed the same issue with patch 41, unfortunately the fix was unintentionally added only in patch 50 whereas it was candidate for patch 41. We'll address this and resubmit.
Thanks! -Rasesh
