> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Friday, March 24, 2017 1:41 PM > Subject: Re: [dpdk-dev] [PATCH 22/39] app/test: octeontx eventdev unit test > infrastructure > > On Thu, Mar 23, 2017 at 11:55:27AM +0000, Van Haaren, Harry wrote: <snip> > > > Subject: [dpdk-dev] [PATCH 22/39] app/test: octeontx eventdev unit test > > > infrastructure > > > > > > add test setup and teardown routines. > > > > > > Signed-off-by: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > > > Hi Harry, > > Thanks for the review. > > > 1) I think the autotest_data.py file needs to be updated to run the test > > command too, > event/sw example at top of patch > > http://dpdk.org/dev/patchwork/patch/21694/ > > Unlike event/sw, Since this test case has the dependency on specific HW. I > prefer to not add to common autotest_data.py.
Ah yes - good point - Ack-ed again for clarity. > > 2) This requires a rebase against latest head, app/test has moved to > > test/test/. > > I will ignore this app/test to test/test move for the remaining patches of > > the series. > > Will fix it v2 Perfect. Acked-by: Harry van Haaren <harry.van.haa...@intel.com>
