> -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Wednesday, March 22, 2017 4:15 PM > To: Mcnamara, John <john.mcnam...@intel.com> > Cc: Trahe, Fiona <fiona.tr...@intel.com>; dev@dpdk.org; De Lara Guarch, > Pablo <pablo.de.lara.gua...@intel.com> > Subject: [PATCH] doc: reformat crypto drivers overview > > Follow the approach in the network devices overview, for the feature > matrix, so it improves readibility and maintainability. >
There are pep8 warnings that should be fixed. Mainly for long lines: $ pep8 doc/guides/conf.py doc/guides/conf.py:318:80: E501 line too long (109 > 79 characters) doc/guides/conf.py:320:80: E501 line too long (105 > 79 characters) doc/guides/conf.py:321:80: E501 line too long (81 > 79 characters) doc/guides/conf.py:322:80: E501 line too long (108 > 79 characters) doc/guides/conf.py:324:80: E501 line too long (122 > 79 characters) doc/guides/conf.py:326:80: E501 line too long (102 > 79 characters) Apart from that it is a good change and a nice generalization of the table building approach. With the above fixed: Acked-by: John McNamara <john.mcnam...@intel.com>