Accept that, and will send v3 to fix it. Thanks for review.
Best regards,
Jeff Guo
-----Original Message-----
From: Wu, Jingjing
Sent: Wednesday, March 22, 2017 8:27 PM
To: Guo, Jia <jia....@intel.com>; Zhang, Helin <helin.zh...@intel.com>
Cc: dev@dpdk.org; sta...@dpdk.org
Subject: RE: [dpdk-dev v2 3/3] test: enable HW CRC strip by default
> -----Original Message-----
> From: Guo, Jia
> Sent: Monday, March 20, 2017 5:58 PM
> To: Zhang, Helin <helin.zh...@intel.com>; Wu, Jingjing
> <jingjing...@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia....@intel.com>; sta...@dpdk.org
> Subject: [dpdk-dev v2 3/3] test: enable HW CRC strip by default
>
> Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF
> drivers, and for most case of kernel driver default enable HW CRC
> strip, if disable HW CRC strip in test app's rxmode, VF driver will
> return fail and result the VF launch failure. So this patch default to enable
> HW CRC strip to let VF launch successful.
>
> Signed-off-by: Jeff Guo <jia....@intel.com>
> Cc: sta...@dpdk.org
> ---
> test/test-pipeline/init.c | 2 +-
> test/test/test_kni.c | 2 +-
> test/test/test_link_bonding.c | 4 ++--
> test/test/test_link_bonding_mode4.c | 2 +-
> test/test/test_link_bonding_rssconf.c | 4 ++--
> test/test/test_pmd_perf.c | 2 +-
> 6 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/test/test-pipeline/init.c b/test/test-pipeline/init.c
> index
> aef082f..00dbc27 100644
> --- a/test/test-pipeline/init.c
> +++ b/test/test-pipeline/init.c
> @@ -105,7 +105,7 @@ static struct rte_eth_conf port_conf = {
> .hw_ip_checksum = 1, /* IP checksum offload enabled */
> .hw_vlan_filter = 0, /* VLAN filtering disabled */
> .jumbo_frame = 0, /* Jumbo Frame Support disabled */
> - .hw_strip_crc = 0, /* CRC stripped by hardware */
> + .hw_strip_crc = 1, /* CRC stripped by hardware */
> },
> .rx_adv_conf = {
> .rss_conf = {
> diff --git a/test/test/test_kni.c b/test/test/test_kni.c index
> 309741c..db17fdf
> 100644
> --- a/test/test/test_kni.c
> +++ b/test/test/test_kni.c
> @@ -92,7 +92,7 @@ static const struct rte_eth_conf port_conf = {
> .hw_ip_checksum = 0,
> .hw_vlan_filter = 0,
> .jumbo_frame = 0,
> - .hw_strip_crc = 0,
> + .hw_strip_crc = 1,
> },
> .txmode = {
> .mq_mode = ETH_DCB_NONE,
> diff --git a/test/test/test_link_bonding.c
> b/test/test/test_link_bonding.c index 3229660..3a1194c 100644
> --- a/test/test/test_link_bonding.c
> +++ b/test/test/test_link_bonding.c
> @@ -172,7 +172,7 @@ struct rte_eth_rxmode rx_mode = {
> .hw_vlan_strip = 1, /**< VLAN strip enabled. */
> .hw_vlan_extend = 0, /**< Extended VLAN disabled. */
> .jumbo_frame = 0, /**< Jumbo Frame Support disabled. */
> - .hw_strip_crc = 0, /**< CRC stripping by hardware disabled. */
> + .hw_strip_crc = 1, /**< CRC stripping by hardware disabled. */
> };
Comment "/**< CRC stripping by hardware disabled. */" need to be Changed too.
