On Mon, Mar 20, 2017 at 07:32:45AM +0000, Liu, Changpeng wrote:
> > diff --git a/lib/librte_vhost/rte_virtio_net.h
> > b/lib/librte_vhost/rte_virtio_net.h
> > index fa98d29..e19ebad 100644
> > --- a/lib/librte_vhost/rte_virtio_net.h
> > +++ b/lib/librte_vhost/rte_virtio_net.h
> > @@ -42,14 +42,10 @@
> > #include <stdint.h>
> > #include <linux/vhost.h>
> > #include <linux/virtio_ring.h>
> > -#include <linux/virtio_net.h>
> > #include <sys/eventfd.h>
> > -#include <sys/socket.h>
> > -#include <linux/if.h>
> >
> > #include <rte_memory.h>
> > #include <rte_mempool.h>
> > -#include <rte_ether.h>
>
> One small nits here, remove net specific headers is good idea, since API
> rte_vhost_dequeue_burst/rte_vhost_enqueue_burst
> has "struct rte_mbuf" declared parameter, user must include <rte_mbuf.h> in
> their own applications.
> Can we add extra line "struct rte_mbuf;" before the
> rte_vhost_dequeue_burst/rte_vhost_enqueue_burst
> APIs to avoid such extra includes?
Good suggestion, and sure, we can do that.
And I had a plan to add a config option to not build the net driver
when it's given. Thus, it could give us a vhost with minimum dependences,
say no dependence on mbuf, on rte_malloc and etc.
I was thinking to name it to "CONFIG_RTE_VHOST_MINIMUM", or something
like that. It's likely something I will do in the next release.
--yliu
