On 03/14/2017 10:46 AM, Maxime Coquelin wrote:


On 03/03/2017 10:51 AM, Yuanhan Liu wrote:
Introduce few APIs to set/get/enable/disable driver features.

Signed-off-by: Yuanhan Liu <yuanhan....@linux.intel.com>
---
 lib/librte_vhost/rte_vhost_version.map | 10 ++++
 lib/librte_vhost/rte_virtio_net.h      |  9 ++++
 lib/librte_vhost/socket.c              | 90
++++++++++++++++++++++++++++++++++
 3 files changed, 109 insertions(+)

Nice!
Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>

I wonder whether we could protect from setting/enabling/disabling
features once negotiation is done?

Oh, I forgot one comment on this patch.
Since these new functions are part to the API, shouldn't them be
documented?

Maxime

Reply via email to