> On Mar 7, 2017, at 9:05 AM, Pascal Mazon <pascal.ma...@6wind.com> wrote: > > Hi Keith, > > I'm working on a v3 for that series: > > - I added info regarding flow API support in tap.rst doc > - I fixed support for kernels where flower/vlan was not supported. > > Do you have any other remarks, or can I send the v3 (hopefully ok for > integration)? > > I'll send a v2 for the latest series (introducing remote capture), > because struct pmd_internals changed (whitespaces). > Same question there, do you have remarks?
I think I am ok with everything we discussed and you can send your v2/v3 when you want. > > Thank you. > > Best regards, > Pascal > > On Mon, 6 Mar 2017 18:05:26 +0100 > Pascal Mazon <pascal.ma...@6wind.com> wrote: > >> This series add support for the flow API in tap PMD. >> >> It enables filtering specific packets incoming on the tap netdevice, >> to process only desired ones. Under the hood, it uses kernel TC >> (traffic control), which takes place very early in the stack, and >> supports most common pattern items and actions defined in the flow >> API. >> >> This series applies on top of: >> >> [PATCH 0/6] net/tap: add additional management ops >> >> v2 changes: >> - support compilation on kernels < 4.2 (where flower support >> appeared) >> - set whitespaces in tap.h >> - remove unnecessary goto >> >> Pascal Mazon (4): >> net/tap: move private elements to external header >> net/tap: add preliminary support for rte_flow >> net/tap: add netlink back-end for flow API >> net/tap: add basic flow API patterns and actions >> >> doc/guides/nics/features/tap.ini | 1 + >> drivers/net/tap/Makefile | 44 ++ >> drivers/net/tap/rte_eth_tap.c | 94 ++-- >> drivers/net/tap/tap.h | 77 +++ >> drivers/net/tap/tap_flow.c | 1084 >> ++++++++++++++++++++++++++++++++++++++ >> drivers/net/tap/tap_flow.h | 58 ++ >> drivers/net/tap/tap_netlink.c | 367 +++++++++++++ >> drivers/net/tap/tap_netlink.h | 69 +++ >> drivers/net/tap/tap_tcmsgs.c | 378 +++++++++++++ >> drivers/net/tap/tap_tcmsgs.h | 63 +++ 10 files changed, 2202 >> insertions(+), 33 deletions(-) create mode 100644 >> drivers/net/tap/tap.h create mode 100644 drivers/net/tap/tap_flow.c >> create mode 100644 drivers/net/tap/tap_flow.h >> create mode 100644 drivers/net/tap/tap_netlink.c >> create mode 100644 drivers/net/tap/tap_netlink.h >> create mode 100644 drivers/net/tap/tap_tcmsgs.c >> create mode 100644 drivers/net/tap/tap_tcmsgs.h >> > Regards, Keith
