> -----Original Message----- > From: Chas Williams [mailto:3ch...@gmail.com] > > + */ > > +#ifndef RTE_AVP_ALIGNMENT > > +#define RTE_AVP_ALIGNMENT 64 > > +#endif > > This is already provided by DPDK as CONFIG_RTE_CACHE_LINE_SIZE
We took another look at our usage of this. We need it for another component's compile, but we'll refactor this out so that it is not needed in this file. > > > + * Defines the number of mbuf pools supported per device (1 per socket) > > + * @note This value should be equal to RTE_MAX_NUMA_NODES > > + */ > > +#define RTE_AVP_MAX_MEMPOOLS (8) > > Perhaps it should be RTE_MAX_NUMA_NODES then? I'll remove the comment because it is more about this aligning with the host max rather than the local max. > The ()'s around constants aren't really necessary. You aren't going to > get side effects. Ok. Will remove.
