> -----Original Message----- > From: Legacy, Allain [mailto:allain.leg...@windriver.com] > Sent: Friday, March 3, 2017 12:19 PM > To: Dumitrescu, Cristian <cristian.dumitre...@intel.com>; Yuanhan Liu > <yuanhan....@linux.intel.com>; Richardson, Bruce > <bruce.richard...@intel.com> > Cc: dev@dpdk.org; Jolliffe, Ian (Wind River) <ian.jolli...@windriver.com> > Subject: RE: [dpdk-dev] [PATCH 1/5] cfgfile: configurable comment character > > > -----Original Message----- > > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > > I disagree here. I think we must control the set of allowed separators to > > avoid confusion. > I don't understand. What will be confusing? The app owns the file format > and is responsible to ensure that it is parseable. >
I does not make sense to allow letters, numbers, formatting characters (tabs, lf, cr, etc), unprintable characters, etc as comment separators. In fact, if you look on the ASCII set, there are about 5 chars out of 256 that can be used as comment separators (the ones I listed earlier). The others are not suitable as comment separators, so none of the commonly used parsers allow them. The API should not allow options that do not make sense.
