On Tue, 31 Jan 2017 10:44:53 -0700
Ben Walker <benjamin.wal...@intel.com> wrote:

> +     if (physaddr == RTE_BAD_PHYS_ADDR) {
>               RTE_LOG(ERR, EAL,
> -                     "Cannot open /proc/self/pagemap: %s. "
> -                     "virt2phys address translation will not work\n",
> +                     "Cannot obtain physical addresses: %s. "
> +                     "Only vfio will function.\n",

Please don't split a single error message across multiple lines. It makes
it harder for user to find the source code lines with simple grep.
Better to just have one long line for format string, or better yet be less 
wordy.

Yes, the existing DPDK code has lots of these issues.

Reply via email to