> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, February 15, 2017 4:53 PM > To: Jan Blunck <jblu...@infradead.org>; Shreyansh Jain > <shreyansh.j...@nxp.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v11 07/13] pci: split match and probe > > 2017-02-15 11:45, Jan Blunck: > > > /** > > > + * Match the PCI Driver and Device using the ID Table > > > + * > > > + * @param pci_drv > > > + * PCI driver from which ID table would be extracted > > > + * @param pci_dev > > > + * PCI device to match against the driver > > > + * @return > > > + * 0 for successful match > > > + * !0 for unsuccessful match > > > + */ > > > +int > > > +rte_pci_match(const struct rte_pci_driver *pci_drv, > > > + const struct rte_pci_device *pci_dev); > > > > I don't think this symbol needs to be exported and visible outside of EAL. > > If I remember well, Shreyansh wants to re-use it for its own bus which > is closed to PCI. > I think it is weird and we could look for another way to re-use some code. > Shreyansh?
>From what I recall pci_match _was_ exported was because: 1. earlier match was a callback for bus. Which is not the case now 2. idea was that some other Buses might be able to re-use this. NXP DPAA2 implementation (in early stages). I don't think this is needed anymore.
