On Thu, Jan 26, 2017 at 11:05:22AM +0000, Ferruh Yigit wrote: > On 1/26/2017 4:41 AM, Rahul Lakkireddy wrote: > > On Wednesday, January 01/25/17, 2017 at 17:43:57 +0530, Ferruh Yigit wrote: > >> On 1/24/2017 8:48 PM, Emmanuel Roullit wrote: > >>> Found with clang static analysis: > >>> drivers/net/cxgbe/sge.c:900:3: warning: > >>> Value stored to 'in_use' is never read > >>> in_use += q->size; > >>> ^ ~~~~~~~ > >>> > >>> Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API") > > > > This fixes line seems to be wrong. Should be: > > > > > > >>> > >>> Signed-off-by: Emmanuel Roullit <emmanuel.roul...@gmail.com> > > > Fixes: 4a01078b4fd1 ("cxgbe: add Tx support") > Cc: sta...@dpdk.org
I doubt the necessary of picking it to a stable release: it doesn't fix a real bug after all. Therefore, I will drop it for v16.11.1. --yliu > > Acked-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> > > > Applied to dpdk-next-net/master, thanks. > > (patch 2/3 and 3/3 merged)