On 2/7/2017 3:45 PM, Wu, Jingjing wrote:
>>> +#ifdef RTE_LIBRTE_IEEE1588
>>> +#define I40E_TX_IEEE1588_TMST PKT_TX_IEEE1588_TMST #else #define
>>> +I40E_TX_IEEE1588_TMST 0 #endif
>>> +
>>>  #define I40E_TX_CKSUM_OFFLOAD_MASK (                \
>>>             PKT_TX_IP_CKSUM |                \
>>>             PKT_TX_L4_MASK |                 \
>>> @@ -87,7 +93,9 @@
>>>             PKT_TX_OUTER_IP_CKSUM | \
>>>             PKT_TX_TCP_SEG |        \
>>>             PKT_TX_QINQ_PKT |       \
>>> -           PKT_TX_VLAN_PKT)
>>> +           PKT_TX_VLAN_PKT |       \
>>> +           PKT_TX_TUNNEL_MASK |    \
>>> +           I40E_TX_IEEE1588_TMST)
>>
>> PKT_TX_IEEE1588_TMST added into I40E_TX_OFFLOAD_MASK, but not into
>> PKT_TX_OFFLOAD_MASK (patch 4/4)
>>
>> Shouldn't PKT_TX_OFFLOAD_MASK be a super set of driver ones. Otherwise
>> PKT_TX_IEEE1588_TMST will be marked as not supported according below
>> XOR logic.
>>
> 
> Yes, you are right. Should I send a new version patch set? Or just update the 
> [4/4]?
Please send a new version of the set.

Thanks,
ferruh

Reply via email to