On 2/7/2017 10:24 AM, Ferruh Yigit wrote:
> On 2/3/2017 11:36 PM, Qi Zhang wrote:
>> dev_flags is wrong overwritten by RTE_ETH_DEV_DETACHABLE after
>> rte_eth_copy_pci_info.
>>
>> Fixes: 22dda618c00c ("pci: separate detaching ethernet ports from PCI
>> devices")
>>
>> Signed-off-by: Qi Zhang <qi.z.zh...@intel.com>
>> ---
>> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
>> drivers/net/e1000/igb_ethdev.c | 4 ++--
>> drivers/net/fm10k/fm10k_ethdev.c | 2 +-
>> drivers/net/i40e/i40e_ethdev.c | 2 +-
>> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>> drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--
>> drivers/net/nfp/nfp_net.c | 2 +-
>> drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
>> 8 files changed, 10 insertions(+), 10 deletions(-)
>>
>
> Hi Qi,
>
> Thanks for the fix.
>
> Is following missed, or intentionally excluded:
>
> drivers/net/e1000/em_ethdev.c
> drivers/net/virtio/virtio_ethdev.c
Hi Yuanhan,
I saw while checking for this, there can be an issue in virtio for this
path, can you please check:
eth_virtio_dev_init()
set-some-eth_dev-dev_flags
virtio_init_device()
rte_eth_copy_pci_info()
eth_dev->data->dev_flags = 0; <---- Reset previous flags
Regards,
ferruh
