On Sat, 4 Feb 2017 16:37:54 +0800 Wei Dai <wei....@intel.com> wrote:
> + PMD_INIT_LOG(ERR, "If ixgbe MAC type is not X550 or X550EM_x or > " > + "X550EM_a, the filter mode must be signature or > perfect, other mode " > + "is not supported ! Current MAC type = %d filter mode = > %d", > + (int)(hw->mac.type), (int)mode); > return -ENOSYS; Having better messages is good. Please punctuate correctly, and ! is not necessary. Please try and keep it to one line, having really long log messages doesn't help. Also, breaking a string makes it harder to use grep to find the source.
